From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: <linux-kernel@vger.kernel.org>, Jaroslav Kysela <perex@perex.cz>,
<alsa-devel@alsa-project.org>,
<patches@opensource.wolfsonmicro.com>,
"Mark Brown" <broonie@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Takashi Iwai <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [PATCH 5/6] ASoC: wm8978: Add OF device ID table
Date: Wed, 5 Apr 2017 09:51:54 +0100 [thread overview]
Message-ID: <20170405085154.GY6986@localhost.localdomain> (raw)
In-Reply-To: <20170404192630.11408-6-javier@osg.samsung.com>
On Tue, Apr 04, 2017 at 03:26:29PM -0400, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Before this patch:
>
> $ modinfo sound/soc/codecs/snd-soc-wm8978.ko | grep alias
> alias: i2c:wm8978
>
> After this patch:
>
> $ modinfo sound/soc/codecs/snd-soc-wm8978.ko | grep alias
> alias: i2c:wm8978
> alias: of:N*T*Cwlf,wm8978C*
> alias: of:N*T*Cwlf,wm8978
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2017-04-05 16:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 19:26 [PATCH 0/6] ASoC: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-04-04 19:26 ` [PATCH 1/6] ASoc: rt5645: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoc: rt5645: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 2/6] ASoC: ssm4567: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: ssm4567: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 3/6] ASoC: sta529: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: sta529: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 4/6] ASoC: uda1380: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: uda1380: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 5/6] ASoC: wm8978: Add OF device ID table Javier Martinez Canillas
2017-04-05 8:51 ` Charles Keepax [this message]
2017-04-05 17:30 ` Applied "ASoC: wm8978: Add OF device ID table" to the asoc tree Mark Brown
2017-04-04 19:26 ` [PATCH 6/6] ASoC: rt5677: Add OF device ID table Javier Martinez Canillas
2017-04-05 17:30 ` Applied "ASoC: rt5677: Add OF device ID table" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405085154.GY6986@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox