Re: [PATCH 5/5] IB/qib: Adjust two size determinations in qib_init_pportdata()

Yuval Shaia
2017-04-05T14:33:34Z

On Wed, Apr 05, 2017 at 03:55:39PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 5 Apr 2017 15:00:44 +0200
>
> * Replace the specification of two data structures by pointer dereferences
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> * Delete the local variable "size" which became unnecessary with
> this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/infiniband/hw/qib/qib_init.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c
> index 101580f0460a..e223226ed94d 100644
> --- a/drivers/infiniband/hw/qib/qib_init.c
> +++ b/drivers/infiniband/hw/qib/qib_init.c
> @@ -222,8 +222,6 @@ struct qib_ctxtdata *qib_create_ctxtdata(struct qib_pportdata *ppd, u32 ctxt,
> int qib_init_pportdata(struct qib_pportdata *ppd, struct qib_devdata *dd,
> u8 hw_pidx, u8 port)
> {
> - int size;
> -
> ppd->dd = dd;
> ppd->hw_pidx = hw_pidx;
> ppd->port = port; /* IB port number, not index */
> @@ -270,13 +268,14 @@ int qib_init_pportdata(struct qib_pportdata *ppd, struct qib_devdata *dd,
> if (!ppd->congestion_entries)
> goto bail_1;
>
> - size = sizeof(struct cc_table_shadow);
> - ppd->ccti_entries_shadow = kzalloc(size, GFP_KERNEL);
> + ppd->ccti_entries_shadow = kzalloc(sizeof(*ppd->ccti_entries_shadow),
> + GFP_KERNEL);
> if (!ppd->ccti_entries_shadow)
> goto bail_2;
>
> - size = sizeof(struct ib_cc_congestion_setting_attr);
> - ppd->congestion_entries_shadow = kzalloc(size, GFP_KERNEL);
> + ppd->congestion_entries_shadow = kzalloc(sizeof(*ppd
> + ->congestion_entries_shadow),
> + GFP_KERNEL);

Not related to this patch but is related to your patch-set - can you check
the array allocations in lines 264 and 268?

Besides that:
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

> if (!ppd->congestion_entries_shadow)
> goto bail_3;
>
> --
> 2.12.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html