From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [for-next][PATCH 3/7] ftrace: Return NULL at end of t_start() instead of calling t_hash_start()
Date: Wed, 05 Apr 2017 12:21:12 -0400 [thread overview]
Message-ID: <20170405162147.140353943@goodmis.org> (raw)
In-Reply-To: 20170405162109.825936532@goodmis.org
[-- Attachment #1: 0003-ftrace-Return-NULL-at-end-of-t_start-instead-of-call.patch --]
[-- Type: text/plain, Size: 747 bytes --]
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The loop in t_start() of calling t_next() will call t_hash_start() if the
pos is beyond the functions and enters the hash items. There's no reason to
check if p is NULL and call t_hash_start(), as that would be redundant.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 3165b7f840e6..421530831ddd 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -3255,7 +3255,7 @@ static void *t_start(struct seq_file *m, loff_t *pos)
}
if (!p)
- return t_hash_start(m, pos);
+ return NULL;
return iter;
}
--
2.10.2
next prev parent reply other threads:[~2017-04-05 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 16:21 [for-next][PATCH 0/7] tracing: Updates to filter probes and early ftrace init Steven Rostedt
2017-04-05 16:21 ` [for-next][PATCH 1/7] ftrace: Clean up __seq_open_private() return check Steven Rostedt
2017-04-05 16:21 ` [for-next][PATCH 2/7] ftrace: Assign iter->hash to filter or notrace hashes on seq read Steven Rostedt
2017-04-05 16:21 ` Steven Rostedt [this message]
2017-04-05 16:21 ` [for-next][PATCH 4/7] ftrace: Update func_pos in t_start() when all functions are enabled Steven Rostedt
2017-04-05 16:21 ` [for-next][PATCH 5/7] ftrace: Create separate t_func_next() to simplify the function / hash logic Steven Rostedt
2017-04-05 16:21 ` [for-next][PATCH 6/7] ftrace: Have init/main.c call ftrace directly to free init memory Steven Rostedt
2017-04-05 16:21 ` [for-next][PATCH 7/7] tracing/kprobes: expose maxactive for kretprobe in kprobe_events Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405162147.140353943@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox