Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to arch_add/remove_memory

Michal Hocko
2017-04-07T14:45:18Z

On Fri 07-04-17 10:32:49, Jerome Glisse wrote:
> On Fri, Apr 07, 2017 at 02:13:49PM +0200, Michal Hocko wrote:
> > On Wed 05-04-17 16:40:11, Jérôme Glisse wrote:
> > > When hotpluging memory we want more information on the type of memory.
> > > This is to extend ZONE_DEVICE to support new type of memory other than
> > > the persistent memory. Existing user of ZONE_DEVICE (persistent memory)
> > > will be left un-modified.
> >
> > My current hotplug rework [1] is touching this path as well. It is not
> > really clear from the chage why you are changing this and what are the
> > further expectations of MEMORY_DEVICE_PERSISTENT. Infact I have replaced
> > for_device with want__memblock [2]. I plan to repost shortly but I would
> > like to understand your modifications more to reduce potential conflicts
> > in the code. Why do you need to distinguish different types of memory
> > anyway.
> >
> > [1] http://lkml.kernel.org/r/20170330115454.32154-1-mhocko@kernel.org
> > [2] the current patchset is in git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git
> > branch attempts/rewrite-mem_hotplug-WIP
>
> This is needed for UNADDRESSABLE memory type introduced in patch 3 and
> the arch specific bits are in patch 4. Basicly for UNADDRESSABLE memory
> i do not want the arch code to create a linear mapping for the range
> being hotpluged. Adding memory_type in this patch allow to distinguish
> between different type of ZONE_DEVICE.

Why don't you use __add_pages directly then?
--
Michal Hocko
SUSE Labs