From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755181AbdDFWwY (ORCPT ); Thu, 6 Apr 2017 18:52:24 -0400 Received: from mail.us.es ([193.147.175.20]:39456 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754281AbdDFWwN (ORCPT ); Thu, 6 Apr 2017 18:52:13 -0400 Date: Fri, 7 Apr 2017 00:52:06 +0200 From: Pablo Neira Ayuso To: Arushi Singhal Cc: Jozsef Kadlecsik , davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] net: netfilter: Remove typedef from "typedef struct bitstr_t". Message-ID: <20170406225206.GA2714@salvia> References: <20170328182413.GA14102@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328182413.GA14102@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2017 at 11:54:13PM +0530, Arushi Singhal wrote: > This patch removes typedefs from struct and renames it from "typedef struct > bitstr_t" to "struct bitstr" as per kernel coding standards." > > Signed-off-by: Arushi Singhal > --- > net/netfilter/nf_conntrack_h323_asn1.c | 80 +++++++++++++++++----------------- > 1 file changed, 40 insertions(+), 40 deletions(-) > > diff --git a/net/netfilter/nf_conntrack_h323_asn1.c b/net/netfilter/nf_conntrack_h323_asn1.c > index fb8cf238a76f..4502c0d6071d 100644 > --- a/net/netfilter/nf_conntrack_h323_asn1.c > +++ b/net/netfilter/nf_conntrack_h323_asn1.c > @@ -91,41 +91,41 @@ struct field { > }; > > /* Bit Stream */ > -typedef struct { > +struct bitstr { Same thing here, I'd suggest you use 'struct h323_bitstr' instead. Thanks!