From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934245AbdDGPFW (ORCPT ); Fri, 7 Apr 2017 11:05:22 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:49789 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933979AbdDGPFQ (ORCPT ); Fri, 7 Apr 2017 11:05:16 -0400 Date: Fri, 7 Apr 2017 17:05:14 +0200 From: Andrew Lunn To: Juergen Borleis Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de, vivien.didelot@savoirfairelinux.com, davem@davemloft.net Subject: Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Message-ID: <20170407150514.GE23415@lunn.ch> References: <20170407081502.30172-1-jbe@pengutronix.de> <20170407081502.30172-5-jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407081502.30172-5-jbe@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2017 at 10:15:02AM +0200, Juergen Borleis wrote: > When the LAN9303 device is in MDIO manged mode, all register accesses must > be done via MDIO. > > Please note: this code is *untested* yet due to the absence of such > configured hardware. It is based on a patch of Stefan Roese from 2014. I looked through the code and i don't see anything obviously wrong. But so long as we get the ABI correct, we can fix everything else later. And the ABI here is just the device tree binding. And that is identical to the i2c binding. The properties just go in a different place in the tree. So please do the *TODO*, you can look at other examples, e.g. the Marvell binding documentation. With that done, i will ACK this code. Andrew