From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbdDHKvJ (ORCPT ); Sat, 8 Apr 2017 06:51:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60530 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdDHKvE (ORCPT ); Sat, 8 Apr 2017 06:51:04 -0400 Date: Sat, 8 Apr 2017 12:50:53 +0200 From: Greg KH To: Prasant Jalan Cc: forest@alittletooquiet.net, arushisinghal19971997@gmail.com, devel@driverdev.osuosl.org, johannes.berg@intel.com, linux-kernel@vger.kernel.org, michael.schacht.hansen@gmail.com Subject: Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue Message-ID: <20170408105053.GA19860@kroah.com> References: <1490443848-5985-1-git-send-email-prasant.jalan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490443848-5985-1-git-send-email-prasant.jalan@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 25, 2017 at 05:40:48PM +0530, Prasant Jalan wrote: > > Replacing spaces with tabs for indetation to fix checkpatch.pl error > "code indent should use tabs where possible". > > > Signed-off-by: Prasant Jalan > --- > > v2: > - improved changelog comments > - fixed only one issue > > > drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++---------------- > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c > index 1835cd1..7ebd1ee 100644 > --- a/drivers/staging/vt6656/rxtx.c > +++ b/drivers/staging/vt6656/rxtx.c > @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate) > } > > static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type, > - u32 frame_length, u16 rate, int need_ack) > + u32 frame_length, u16 rate, int need_ack) No, it should look like: u32 frame_length, u16 rate, int need_ack) Please fix them up that way. thanks, greg k-h