From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdDJEpR (ORCPT ); Mon, 10 Apr 2017 00:45:17 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:34044 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbdDJEpQ (ORCPT ); Mon, 10 Apr 2017 00:45:16 -0400 Date: Mon, 10 Apr 2017 10:15:11 +0530 From: Viresh Kumar To: Arushi Singhal Cc: pure.logic@nexus-software.ie, devel@driverdev.osuosl.org, Alex Elder , outreachy-kernel@googlegroups.com, Johan Hovold , linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [greybus-dev] [PATCH] staging: greybus: compress return logic Message-ID: <20170410044511.GA4377@vireshk-i7> References: <20170325052007.GA4908@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170325052007.GA4908@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-03-17, 10:50, Arushi Singhal wrote: > Simplify function returns by merging assignment and return. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/greybus/loopback.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > index aaf29a5fac83..08e255884206 100644 > --- a/drivers/staging/greybus/loopback.c > +++ b/drivers/staging/greybus/loopback.c > @@ -365,11 +365,8 @@ static void gb_loopback_calculate_stats(struct gb_loopback *gb, bool error); > > static u32 gb_loopback_nsec_to_usec_latency(u64 elapsed_nsecs) > { > - u32 lat; > - > do_div(elapsed_nsecs, NSEC_PER_USEC); > - lat = elapsed_nsecs; > - return lat; > + return elapsed_nsecs; > } > > static u64 __gb_loopback_calc_latency(u64 t1, u64 t2) Acked-by: Viresh Kumar -- viresh