From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: char: Replace fail_printk with fail_print.
Date: Mon, 10 Apr 2017 15:43:32 +0200 [thread overview]
Message-ID: <20170410134332.GB21327@kroah.com> (raw)
In-Reply-To: <58eb2d71.4228ed0a.41ebe.ea26@mx.google.com>
On Mon, Apr 10, 2017 at 12:29:56PM +0530, Varsha Rao wrote:
> As printk is no longer used here, rename the label fail_printk as
> fail_print.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> drivers/char/misc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 5786281..0fed477 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -293,11 +293,11 @@ static int __init misc_init(void)
>
> err = -EIO;
> if (register_chrdev(MISC_MAJOR, "misc", &misc_fops))
> - goto fail_printk;
> + goto fail_print;
> misc_class->devnode = misc_devnode;
> return 0;
>
> -fail_printk:
> +fail_print:
> pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
> class_destroy(misc_class);
That's really a pointless change, don't you think?
sorry,
greg k-h
prev parent reply other threads:[~2017-04-10 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1491806760.git.rvarsha016@gmail.com>
2017-04-10 6:58 ` [PATCH 1/2] drivers: char: Replace bit operation functions with IDA allocator Varsha Rao
2017-04-10 13:45 ` Greg Kroah-Hartman
2017-04-10 6:59 ` [PATCH 2/2] drivers: char: Replace fail_printk with fail_print Varsha Rao
2017-04-10 13:43 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410134332.GB21327@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox