From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers: char: Replace bit operation functions with IDA allocator.
Date: Mon, 10 Apr 2017 15:45:02 +0200 [thread overview]
Message-ID: <20170410134502.GC21327@kroah.com> (raw)
In-Reply-To: <58eb2d3c.e43aed0a.e6c99.eed5@mx.google.com>
On Mon, Apr 10, 2017 at 12:28:59PM +0530, Varsha Rao wrote:
> Replace bit operation functions with IDA allocator functions. As IDA
> allocation is simpler, faster, more space efficient and it generates
> small integer IDs which can be used as minor device numbers.
The allocation is different than the bitfield searching is? How
exactly? What is the old result vs. the new result of this change?
How did you test this?
You have to really sell this change, right now it looks pretty
pointless...
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-10 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1491806760.git.rvarsha016@gmail.com>
2017-04-10 6:58 ` [PATCH 1/2] drivers: char: Replace bit operation functions with IDA allocator Varsha Rao
2017-04-10 13:45 ` Greg Kroah-Hartman [this message]
2017-04-10 6:59 ` [PATCH 2/2] drivers: char: Replace fail_printk with fail_print Varsha Rao
2017-04-10 13:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410134502.GC21327@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox