From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753552AbdDJNpN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Apr 2017 09:45:13 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:43338 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752877AbdDJNpM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Apr 2017 09:45:12 -0400
Date: Mon, 10 Apr 2017 15:45:02 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Matthew Wilcox <mawilcox@microsoft.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers: char: Replace bit operation functions with
 IDA allocator.
Message-ID: <20170410134502.GC21327@kroah.com>
References: <cover.1491806760.git.rvarsha016@gmail.com>
 <58eb2d3c.e43aed0a.e6c99.eed5@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <58eb2d3c.e43aed0a.e6c99.eed5@mx.google.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 10, 2017 at 12:28:59PM +0530, Varsha Rao wrote:
> Replace bit operation functions with IDA allocator functions. As IDA
> allocation is simpler, faster, more space efficient and it generates
> small integer IDs which can be used as minor device numbers.

The allocation is different than the bitfield searching is?  How
exactly?  What is the old result vs. the new result of this change?

How did you test this?

You have to really sell this change, right now it looks pretty
pointless...

thanks,

greg k-h