From: Matthias Kaehlcke <mka@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <mmarek@suse.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Behan Webster <behanw@converseincode.com>,
Greg Hackmann <ghackmann@google.com>,
Grant Grundler <grundler@chromium.org>,
Michael Davidson <md@google.com>,
Peter Foley <pefoley2@pefoley.com>
Subject: Re: [PATCH] kbuild: use -Oz instead of -Os when using clang
Date: Mon, 10 Apr 2017 11:08:04 -0700 [thread overview]
Message-ID: <20170410180804.GA28657@google.com> (raw)
In-Reply-To: <CAK7LNARe61sBVL=zs7kb4BT5UgkBCYdKWa+esWZnT=j3idDdNw@mail.gmail.com>
Hi Masahiro,
El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit:
> 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit:
> >
> >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> >> > This generates smaller resulting object code when compiled with clang.
> >> >
> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> >> > ---
> >> > Makefile | 3 ++-
> >> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/Makefile b/Makefile
> >> > index b2faa9319372..66bcdbf58371 100644
> >> > --- a/Makefile
> >> > +++ b/Makefile
> >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS += $(call cc-option,-fdata-sections,)
> >> > endif
> >> >
> >> > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
> >> > -KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,)
> >> > +KBUILD_CFLAGS += $(call cc-option,-Oz,-Os)
> >> > +KBUILD_CFLAGS += $(call cc-disable-warning,maybe-uninitialized,)
> >> > else
> >> > ifdef CONFIG_PROFILE_ALL_BRANCHES
> >> > KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,)
> >> >
> >>
> >>
> >>
> >> This is the same as the following commit in LLVMLinux
> >> except Author/Signed-off-by.
> >>
> >> Who should the authorship really belong to?
> >
> > (this time without html, sorry for the noise)
> >
> > It should belong to Behan, I missed to add a 'From' tag, sorry about
> > that. Should I resend with the tag or can you fix it when applying the
> > patch?
>
>
> No need to re-send it. I can fixup it manually.
I couldn't locate this patch in your tree, has it been picked up?
Thanks
Matthias
next prev parent reply other threads:[~2017-04-10 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 1:19 [PATCH] kbuild: use -Oz instead of -Os when using clang Matthias Kaehlcke
2017-03-30 16:03 ` Masahiro Yamada
2017-03-30 16:41 ` Matthias Kaehlcke
2017-03-30 17:57 ` Masahiro Yamada
2017-04-10 18:08 ` Matthias Kaehlcke [this message]
2017-04-12 3:38 ` Masahiro Yamada
2017-04-12 20:39 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410180804.GA28657@google.com \
--to=mka@chromium.org \
--cc=behanw@converseincode.com \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mmarek@suse.com \
--cc=pefoley2@pefoley.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).