From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753040AbdDKDsx (ORCPT ); Mon, 10 Apr 2017 23:48:53 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34644 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbdDKDsw (ORCPT ); Mon, 10 Apr 2017 23:48:52 -0400 Date: Mon, 10 Apr 2017 20:48:48 -0700 From: Dmitry Torokhov To: Christophe JAILLET Cc: linux@roeck-us.net, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Input: omap-keypad - fix error handling code Message-ID: <20170411034848.GF4346@dtor-ws> References: <20170408171858.7266-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170408171858.7266-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 08, 2017 at 07:18:58PM +0200, Christophe JAILLET wrote: > According to the previous error handling code, it is likely that > 'goto err_free_keymap' is expected here in order to avoid a memory leak > in error handling path. > > Signed-off-by: Christophe JAILLET Applied, thank you. > --- > drivers/input/keyboard/omap4-keypad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c > index ebc67ba41fe2..940d38b08e6b 100644 > --- a/drivers/input/keyboard/omap4-keypad.c > +++ b/drivers/input/keyboard/omap4-keypad.c > @@ -358,7 +358,7 @@ static int omap4_keypad_probe(struct platform_device *pdev) > "omap4-keypad", keypad_data); > if (error) { > dev_err(&pdev->dev, "failed to register interrupt\n"); > - goto err_free_input; > + goto err_free_keymap; > } > > device_init_wakeup(&pdev->dev, true); > -- > 2.11.0 > -- Dmitry