From: Ingo Molnar <mingo@kernel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
brgerst@gmail.com, torvalds@linux-foundation.org,
akpm@linux-foundation.org, luto@amacapital.net,
linux-kernel@vger.kernel.org, jpoimboe@redhat.com,
luto@kernel.org, peterz@infradead.org, bp@alien8.de,
hpa@zytor.com, dave.hansen@intel.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86/asm: Remove __VIRTUAL_MASK_SHIFT==47 assert
Date: Tue, 11 Apr 2017 09:12:42 +0200 [thread overview]
Message-ID: <20170411071242.GA23772@gmail.com> (raw)
In-Reply-To: <20170405120029.ckl2a5bc3ikydozw@black.fi.intel.com>
* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:
> On Wed, Apr 05, 2017 at 01:50:27PM +0200, Denys Vlasenko wrote:
> > Er.... "Change top bits ... ((47 or 56 [bits] depending on paging mode)"?
> > I know that's wrong and that's not what you meant to say,
> > but it can be read this way too. "47th" instead of "47"
> > would eliminate this reading, but you removed "th".
> >
> > Spell it out to eliminate any chance of confusion:
> >
> > Change top bits to match most significant bit (47th or 56th bit
> > depending on paging mode) in the address.
> >
>
> ---------------------8<-----------------------
>
> From 5dec28ba49387ff444e447213b553506e253616d Mon Sep 17 00:00:00 2001
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Date: Wed, 5 Apr 2017 14:06:15 +0300
> Subject: [PATCH] x86/asm: Fix comment in return_from_SYSCALL_64
>
> On x86-64 __VIRTUAL_MASK_SHIFT depends on paging mode now.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Could you please integrate this into your series to make sure I apply all the
intended+latest bits?
Thanks,
Ingo
next prev parent reply other threads:[~2017-04-11 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 8:07 [PATCHv3 0/7] x86: 5-level paging enabling for v4.12, Part 3 Kirill A. Shutemov
2017-03-30 8:07 ` [PATCHv3 1/7] x86/boot: Detect 5-level paging support Kirill A. Shutemov
2017-04-04 8:28 ` [tip:x86/mm] " tip-bot for Kirill A. Shutemov
2017-03-30 8:07 ` [PATCHv3 2/7] x86/asm: Remove __VIRTUAL_MASK_SHIFT==47 assert Kirill A. Shutemov
2017-04-04 8:29 ` [tip:x86/mm] " tip-bot for Kirill A. Shutemov
2017-04-04 15:36 ` Denys Vlasenko
2017-04-05 11:12 ` Kirill A. Shutemov
2017-04-05 11:50 ` Denys Vlasenko
2017-04-05 12:00 ` Kirill A. Shutemov
2017-04-11 7:12 ` Ingo Molnar [this message]
2017-03-30 8:07 ` [PATCHv3 3/7] x86/mm: Define virtual memory map for 5-level paging Kirill A. Shutemov
2017-04-04 8:29 ` [tip:x86/mm] " tip-bot for Kirill A. Shutemov
2017-03-30 8:07 ` [PATCHv3 4/7] x86/paravirt: Make paravirt code support " Kirill A. Shutemov
2017-04-04 8:30 ` [tip:x86/mm] x86/paravirt: Add 5-level support to the paravirt code tip-bot for Kirill A. Shutemov
2017-03-30 8:07 ` [PATCHv3 5/7] x86/mm: Add basic defines/helpers for CONFIG_X86_5LEVEL Kirill A. Shutemov
2017-04-04 8:30 ` [tip:x86/mm] x86/mm: Add basic defines/helpers for CONFIG_X86_5LEVEL=y tip-bot for Kirill A. Shutemov
2017-03-30 8:07 ` [PATCHv3 6/7] x86/kasan: Extend to support 5-level paging Kirill A. Shutemov
2017-04-04 8:31 ` [tip:x86/mm] x86/kasan: Extend KASAN " tip-bot for Kirill A. Shutemov
2017-03-30 8:07 ` [PATCHv3 7/7] x86/espfix: Add " Kirill A. Shutemov
2017-04-04 8:31 ` [tip:x86/mm] x86/espfix: Add support for " tip-bot for Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411071242.GA23772@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@intel.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox