From: Alexey Klimov <alexey.klimov@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode
Date: Tue, 11 Apr 2017 14:00:15 +0100 [thread overview]
Message-ID: <20170411130015.GC4973@arm.com> (raw)
In-Reply-To: <1490095816-10943-1-git-send-email-sudeep.holla@arm.com>
On Tue, Mar 21, 2017 at 11:30:14AM +0000, Sudeep Holla wrote:
> There exists a race when msg_submit return immediately as there was an
> active request being processed which may have completed just before it's
> checked again in mbox_send_message. This will result in return to the
> caller without waiting in mbox_send_message even when it's blocking Tx.
>
> This patch fixes the issue by waiting for the completion always if Tx
> is in blocking mode.
>
> Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Reported-by: Alexey Klimov <alexey.klimov@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Alexey Klimov <alexey.klimov@arm.com>
> ---
> drivers/mailbox/mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Jassi,
>
> Here are fixes for few issues we encountered when dealing with multiple
> requests on multiple channels simultaneously.
>
> Regards,
> Sudeep
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index 4671f8a12872..160d6640425a 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -260,7 +260,7 @@ int mbox_send_message(struct mbox_chan *chan, void *mssg)
>
> msg_submit(chan);
>
> - if (chan->cl->tx_block && chan->active_req) {
> + if (chan->cl->tx_block) {
> unsigned long wait;
> int ret;
>
> --
> 2.7.4
>
prev parent reply other threads:[~2017-04-11 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 11:30 [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode Sudeep Holla
2017-03-21 11:30 ` [PATCH 2/3] mailbox: skip complete wait event if timer expired Sudeep Holla
2017-03-21 11:30 ` [PATCH 3/3] mailbox: handle empty message in tx_tick Sudeep Holla
2017-03-28 18:20 ` [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode Jassi Brar
2017-03-29 11:34 ` Sudeep Holla
2017-03-29 17:46 ` Jassi Brar
2017-04-11 13:00 ` Alexey Klimov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411130015.GC4973@arm.com \
--to=alexey.klimov@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox