From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384AbdDKNAW (ORCPT ); Tue, 11 Apr 2017 09:00:22 -0400 Received: from foss.arm.com ([217.140.101.70]:60538 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbdDKNAU (ORCPT ); Tue, 11 Apr 2017 09:00:20 -0400 Date: Tue, 11 Apr 2017 14:00:15 +0100 From: Alexey Klimov To: Sudeep Holla , Jassi Brar Cc: linux-kernel@vger.kernel.org, Jassi Brar Subject: Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode Message-ID: <20170411130015.GC4973@arm.com> References: <1490095816-10943-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490095816-10943-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 11:30:14AM +0000, Sudeep Holla wrote: > There exists a race when msg_submit return immediately as there was an > active request being processed which may have completed just before it's > checked again in mbox_send_message. This will result in return to the > caller without waiting in mbox_send_message even when it's blocking Tx. > > This patch fixes the issue by waiting for the completion always if Tx > is in blocking mode. > > Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox") > Cc: Jassi Brar > Reported-by: Alexey Klimov > Signed-off-by: Sudeep Holla Reviewed-by: Alexey Klimov > --- > drivers/mailbox/mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Jassi, > > Here are fixes for few issues we encountered when dealing with multiple > requests on multiple channels simultaneously. > > Regards, > Sudeep > > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c > index 4671f8a12872..160d6640425a 100644 > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -260,7 +260,7 @@ int mbox_send_message(struct mbox_chan *chan, void *mssg) > > msg_submit(chan); > > - if (chan->cl->tx_block && chan->active_req) { > + if (chan->cl->tx_block) { > unsigned long wait; > int ret; > > -- > 2.7.4 >