From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com,
linus.walleij@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111
Date: Tue, 11 Apr 2017 19:10:22 +0100 [thread overview]
Message-ID: <20170411181021.GW17774@n2100.armlinux.org.uk> (raw)
In-Reply-To: <8737df0vzs.fsf@eliezer.anholt.net>
On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote:
> Russell King - ARM Linux <linux@armlinux.org.uk> writes:
>
> > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote:
> >> v5: Move register definitions inside the driver directory, fix build
> >> in COMPILE_TEST and !AMBA mode.
> >
> > Why is it necessary to move the register definitions there, when
> > they're already available in linux/amba/clcd.h and are required
> > for the FB driver?
> >
> > It is absurd to have driver specific register definitions.
>
> Because after v2, v3, and v4, I still didn't have an ack on the patch to
> move the register definitions from linux/amba/clcd.h to
> linux/amba/clcd-reg.h. If you'd like to go back and ack that, I'd reuse
> them.
I don't remember seeing such a patch, sorry.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-04-11 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 1:18 [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 Eric Anholt
2017-04-11 9:17 ` Linus Walleij
2017-04-11 9:26 ` Daniel Vetter
2017-04-11 16:10 ` Eric Anholt
2017-04-11 22:13 ` Eric Anholt
2017-04-12 7:40 ` Linus Walleij
2017-04-12 15:27 ` Neil Armstrong
2017-04-12 16:37 ` Stephen Boyd
2017-04-12 23:13 ` Russell King - ARM Linux
2017-04-11 9:37 ` Russell King - ARM Linux
2017-04-11 16:06 ` Eric Anholt
2017-04-11 18:10 ` Russell King - ARM Linux [this message]
2017-04-11 21:00 ` Eric Anholt
2017-04-12 22:51 ` Russell King - ARM Linux
2017-04-20 19:48 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411181021.GW17774@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.cooksey@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox