From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Thierry Escande <thierry.escande@collabora.com>,
linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>,
cocci <cocci@systeme.lip6.fr>
Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files
Date: Tue, 11 Apr 2017 20:42:33 +0200 [thread overview]
Message-ID: <20170411184233.GB26792@kroah.com> (raw)
In-Reply-To: <1491934554.17839.13.camel@perches.com>
On Tue, Apr 11, 2017 at 11:15:54AM -0700, Joe Perches wrote:
> On Tue, 2017-04-11 at 16:09 +0200, Greg Kroah-Hartman wrote:
> > Care to use "real" kernel variable types please? u8, u16, and others
> > are you friend, uint8_t really isn't what we prefer, and checkpatch
> > should tell you that...
>
> checkpatch doesn't warn about "u?int\d+_t" types unless
> --strict is enabled and most likely it shouldn't.
For brand new drivers, it's a good thing to run, to keep maintainers
from complaining about obvious things :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-11 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 9:14 [PATCH 0/2] Google VPD sysfs driver Thierry Escande
2017-04-11 9:14 ` [PATCH 1/2] firmware: Google VPD: import lib_vpd source files Thierry Escande
2017-04-11 14:09 ` Greg Kroah-Hartman
2017-04-11 14:28 ` Thierry Escande
2017-04-11 18:15 ` Joe Perches
2017-04-11 18:42 ` Greg Kroah-Hartman [this message]
2017-04-11 18:50 ` Joe Perches
2017-04-11 14:10 ` Greg Kroah-Hartman
2017-04-11 14:11 ` Greg Kroah-Hartman
2017-04-11 14:31 ` Thierry Escande
2017-04-11 9:14 ` [PATCH 2/2] firmware: Google VPD sysfs driver Thierry Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411184233.GB26792@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox