From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbdDLBrb (ORCPT ); Tue, 11 Apr 2017 21:47:31 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48885 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751608AbdDLBr2 (ORCPT ); Tue, 11 Apr 2017 21:47:28 -0400 Date: Tue, 11 Apr 2017 18:47:23 -0700 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:rcu/next 51/58] mm/mmu_notifier.c:259:14: error: 'struct srcu_struct' has no member named 'per_cpu_ref' Reply-To: paulmck@linux.vnet.ibm.com References: <201704120749.qzDAIUMS%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704120749.qzDAIUMS%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17041201-0048-0000-0000-00000156DA61 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006920; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00846289; UDB=6.00417417; IPR=6.00624723; BA=6.00005284; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015013; XFM=3.00000013; UTC=2017-04-12 01:47:26 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041201-0049-0000-0000-0000406CB628 Message-Id: <20170412014723.GC3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-11_20:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704120014 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 07:44:53AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > head: b9d38ad8ef2a0ae0ba6e03ac6bf8085382a9c98c > commit: 89489e6fa42785b3fc4c78f46c78cb73b9a164d3 [51/58] srcu: Create a tiny SRCU > config: x86_64-randconfig-ne0-04120549 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > git checkout 89489e6fa42785b3fc4c78f46c78cb73b9a164d3 > # save the attached .config to linux build tree > make ARCH=x86_64 > > Note: the rcu/rcu/next HEAD b9d38ad8ef2a0ae0ba6e03ac6bf8085382a9c98c builds fine. > It only hurts bisectibility. Commits in wrong order, fixed! Thanx, Paul > All error/warnings (new ones prefixed by >>): > > In file included from include/uapi/linux/stddef.h:1:0, > from include/linux/stddef.h:4, > from include/uapi/linux/posix_types.h:4, > from include/uapi/linux/types.h:13, > from include/linux/types.h:5, > from include/linux/list.h:4, > from include/linux/rculist.h:9, > from mm/mmu_notifier.c:12: > mm/mmu_notifier.c: In function 'do_mmu_notifier_register': > >> mm/mmu_notifier.c:259:14: error: 'struct srcu_struct' has no member named 'per_cpu_ref' > BUG_ON(!srcu.per_cpu_ref); > ^ > include/linux/compiler.h:179:42: note: in definition of macro 'unlikely' > # define unlikely(x) __builtin_expect(!!(x), 0) > ^ > >> mm/mmu_notifier.c:259:2: note: in expansion of macro 'BUG_ON' > BUG_ON(!srcu.per_cpu_ref); > ^~~~~~ > > vim +259 mm/mmu_notifier.c > > cddb8a5c Andrea Arcangeli 2008-07-28 253 BUG_ON(atomic_read(&mm->mm_users) <= 0); > cddb8a5c Andrea Arcangeli 2008-07-28 254 > 21a92735 Sagi Grimberg 2012-10-08 255 /* > 21a92735 Sagi Grimberg 2012-10-08 256 * Verify that mmu_notifier_init() already run and the global srcu is > 21a92735 Sagi Grimberg 2012-10-08 257 * initialized. > 21a92735 Sagi Grimberg 2012-10-08 258 */ > 21a92735 Sagi Grimberg 2012-10-08 @259 BUG_ON(!srcu.per_cpu_ref); > 21a92735 Sagi Grimberg 2012-10-08 260 > 35cfa2b0 Gavin Shan 2012-10-25 261 ret = -ENOMEM; > 35cfa2b0 Gavin Shan 2012-10-25 262 mmu_notifier_mm = kmalloc(sizeof(struct mmu_notifier_mm), GFP_KERNEL); > > :::::: The code at line 259 was first introduced by commit > :::::: 21a92735f660eaecf69a6f2e777f18463760ec32 mm: mmu_notifier: have mmu_notifiers use a global SRCU so they may safely schedule > > :::::: TO: Sagi Grimberg > :::::: CC: Linus Torvalds > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation