From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbdDLGRA (ORCPT ); Wed, 12 Apr 2017 02:17:00 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:36217 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbdDLGQ5 (ORCPT ); Wed, 12 Apr 2017 02:16:57 -0400 Date: Wed, 12 Apr 2017 11:46:52 +0530 From: Viresh Kumar To: Eduardo Valentin Cc: Rafael Wysocki , Javi Merino , Zhang Rui , Amit Daniel Kachhap , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot Subject: Re: [PATCH 03/17] thermal: cpu_cooling: Replace cpufreq_device with cpufreq_dev Message-ID: <20170412061652.GA5910@vireshk-i7> References: <1ebaf8113e79154e9b8e7696c4e1c70791d26e14.1489640000.git.viresh.kumar@linaro.org> <20170411173330.GA5528@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411173330.GA5528@localhost.localdomain> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-04-17, 10:33, Eduardo Valentin wrote: > On Thu, Mar 16, 2017 at 10:59:38AM +0530, Viresh Kumar wrote: > > Objects of "struct cpufreq_cooling_device" are named a bit > > inconsistently. Lets use cpufreq_dev everywhere. > > > > Naming is always a matter of taste.. but I frankly cannot see how this > patch improves anything here. cpufreq_dev is still misleading. I wasn't trying to get to a better name, but rather be consistent. > Here other options: > cpufreq_cooling_dev: not misleading but, may a bit too long.. > cpufreq_cdev: better, but still, not a char dev I will go for the second one. -- viresh