From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbdDLGtz (ORCPT ); Wed, 12 Apr 2017 02:49:55 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:34516 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbdDLGtu (ORCPT ); Wed, 12 Apr 2017 02:49:50 -0400 From: David Carrillo-Cisneros To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Andi Kleen , Simon Que , Wang Nan , Jiri Olsa , He Kuang , Masami Hiramatsu , Stephane Eranian , Paul Turner , David Carrillo-Cisneros Subject: [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key Date: Tue, 11 Apr 2017 23:49:17 -0700 Message-Id: <20170412064919.92449-6-davidcc@google.com> X-Mailer: git-send-email 2.12.2.715.g7642488e1d-goog In-Reply-To: <20170412064919.92449-1-davidcc@google.com> References: <20170412064919.92449-1-davidcc@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My fat-fingering of sort keys in .perfconfig was a common cause of perf report silently terminating without apparent error. This was because 1) error in setup_sorting in cmd_report was ignored and 2) no message was log in UI browser that would prevent UI from exit before user prompt. Fix both. Signed-off-by: David Carrillo-Cisneros --- tools/perf/builtin-report.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index c18158b83eb1..19a69ca0e9c9 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -987,12 +987,15 @@ int cmd_report(int argc, const char **argv) else use_browser = 0; - if (setup_sorting(session->evlist) < 0) { + ret = setup_sorting(session->evlist); + if (ret < 0) { if (sort_order) parse_options_usage(report_usage, options, "s", 1); if (field_order) parse_options_usage(sort_order ? NULL : report_usage, options, "F", 1); + if (!sort_order && !field_order) + pr_err("Couldn't setup sort order. Is .perfconfig correct?\n"); goto error; } -- 2.12.2.715.g7642488e1d-goog