From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753109AbdDLKdp (ORCPT <rfc822;w@1wt.eu>);
        Wed, 12 Apr 2017 06:33:45 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60854 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752450AbdDLKdn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Apr 2017 06:33:43 -0400
X-ME-Sender: <xms:hgLuWP7s4MFxNk6JAalkG917ai_ovMIdO_wGz-ZBIop9MtVhgEuiPw>
X-Sasl-enc: FppU2g+pcHCJvPPq4lnbqdWMdlYSW6JJCBaVRsYbzX2F 1491993222
Date: Wed, 12 Apr 2017 12:33:33 +0200
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux-Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thierry Escande <thierry.escande@collabora.com>
Subject: Re: linux-next: build failure after merge of the char-misc tree
Message-ID: <20170412103333.GD11657@kroah.com>
References: <20170412151859.38f188a2@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170412151859.38f188a2@canb.auug.org.au>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 12, 2017 at 03:18:59PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the char-misc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/firmware/google/memconsole-x86-legacy.c:23:0:
> arch/x86/include/uapi/asm/e820.h:66:23: error: 'E820_X_MAX' undeclared here (not in a function)
>   struct e820entry map[E820_X_MAX];
>                        ^
> 
> Caused by commit
> 
>   afe9dba4f9ae ("firmware: google memconsole: Move specific EBDA parts")
> 
> interacting with commit
> 
>   66441bd3cfdc ("x86/boot/e820: Move asm/e820.h to asm/e820/api.h")
> 
> from the tip tree.
> 
> I applied the following merge fix patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 12 Apr 2017 15:12:12 +1000
> Subject: [PATCH] firmware: google memconsole: merge fix for e820.h move
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/firmware/google/memconsole-x86-legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/google/memconsole-x86-legacy.c b/drivers/firmware/google/memconsole-x86-legacy.c
> index 529078c62488..99df2749c4c5 100644
> --- a/drivers/firmware/google/memconsole-x86-legacy.c
> +++ b/drivers/firmware/google/memconsole-x86-legacy.c
> @@ -20,7 +20,7 @@
>  #include <linux/dmi.h>
>  #include <linux/mm.h>
>  #include <asm/bios_ebda.h>
> -#include <asm/e820.h>
> +#include <asm/e820/api.h>
>  #include <linux/acpi.h>
>  
>  #include "memconsole.h"
> -- 
> 2.11.0

Thanks for the patch, I'll keep it around for when things get merged to
Linus if needed.

greg k-h