From: Christoph Hellwig <hch@infradead.org>
To: Leno Hou <lenohou@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function
Date: Wed, 12 Apr 2017 10:32:28 -0700 [thread overview]
Message-ID: <20170412173228.GB23054@infradead.org> (raw)
In-Reply-To: <CAGQVrL_2EanSVKkMEP_fBaeWSwu=tZYSq79nzOy-wXQ9m1WOuQ@mail.gmail.com>
On Wed, Apr 12, 2017 at 06:03:10PM +0800, Leno Hou wrote:
> 1. Actually, this is cleanup of the code to human being read but not
> optimize. And When I compiled the kernel
> and checked with object code . It proved as same as before. So it's no
> need to test this change.
>
> 2. This Simple B+ Tree in Memory was used by SCSI driver QLA2XXX. so it
> would be better to merge this
> cleanup for future optimize. Thanks.
If you care about the btree code a good first step would be to write a
test suite instead of micro-optimizing it out of the blue without
actually being able to test it.
next prev parent reply other threads:[~2017-04-12 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 6:53 [PATCH v1]] lib/btree.c: optimise the code by previously getpos function Leno Hou
2017-04-11 16:20 ` Christoph Hellwig
[not found] ` <CAGQVrL_2EanSVKkMEP_fBaeWSwu=tZYSq79nzOy-wXQ9m1WOuQ@mail.gmail.com>
2017-04-12 17:32 ` Christoph Hellwig [this message]
2017-04-19 14:48 ` Leno Hou
2017-04-28 16:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412173228.GB23054@infradead.org \
--to=hch@infradead.org \
--cc=lenohou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox