From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756164AbdDMJ4g (ORCPT ); Thu, 13 Apr 2017 05:56:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:48530 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbdDMJ4d (ORCPT ); Thu, 13 Apr 2017 05:56:33 -0400 Date: Thu, 13 Apr 2017 11:56:30 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: Jens Axboe , Omar Sandoval , Ming Lei , Bart Van Assche , Hannes Reinecke , Linux Block Layer Mailinglist , Linux Kernel Mailinglist Subject: Re: [PATCH] block: bios with an offset are always gappy Message-ID: <20170413095630.GE6734@linux-x5ow.site> References: <20170413080629.7610-1-jthumshirn@suse.de> <20170413094835.GA28413@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170413094835.GA28413@lst.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2017 at 11:48:35AM +0200, Christoph Hellwig wrote: > I think we should also turns this into a WARN_ON_ONCE + error return.. > > But do you have an exact btrfsprogs version and command line? I do a lot > of testing that involves mkfs.btrfs on nvme and haven't seen it.. Sure, it's: mkfs.btrfs, part of btrfs-progs v4.5.3+20160729 Qemu is 2.6.2 [...] > > I think the code in NVMe (and potentially the other drivers using > virt_queue_boundary) is bogus. All of them are actually fine with > gaps in the protocol, as long as the gaps are aligned to said boundary. > > So I suspect what we really need is to fix up NVMe, and after that > we could even relax the above check, to not check for offset but > offset & queue_virt_boundary(q). That's what I tried doing the last two days but as we're rather late in the rc cycle and it is a regression that came in with -rc1 I'd rather like to have it fixed or at least have a band aid in place. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850