From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754736AbdDMOyF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Apr 2017 10:54:05 -0400
Received: from mail.kernel.org ([198.145.29.136]:42656 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753592AbdDMOyA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Apr 2017 10:54:00 -0400
Date: Thu, 13 Apr 2017 11:53:50 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid
 sorting key
Message-ID: <20170413145350.GR3275@kernel.org>
References: <20170412064919.92449-1-davidcc@google.com>
 <20170412064919.92449-6-davidcc@google.com>
 <20170412081721.GC17517@krava>
 <CALcN6mhCpTBvcO2Xt4388HMY0a1KLoJFM=4N2mQ3E91rp3g2fg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALcN6mhCpTBvcO2Xt4388HMY0a1KLoJFM=4N2mQ3E91rp3g2fg@mail.gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Apr 12, 2017 at 09:34:37AM -0700, David Carrillo-Cisneros escreveu:
> > On Tue, Apr 11, 2017 at 11:49:17PM -0700, David Carrillo-Cisneros wrote:
> >> My fat-fingering of sort keys in .perfconfig was a common cause of
> >> perf report silently terminating without apparent error.
> >>
> >> This was because 1) error in setup_sorting in cmd_report was ignored
> >> and 2) no message was log in UI browser that would prevent UI from
> >> exit before user prompt. Fix both.
> >
> > there's UI init ahead of this code.. I had to move it
> > below your code to spot any error message
> >
> > there's other errors further on.. perhaps we should move it even further ;-)
> > or cancel the ui before the error is printed
> 
> Probably canceling ui on error is the more robust way to go. I will
> look into it.

So I'll wait for a v2 for this specific patch.