From: Simon Horman <horms@verge.net.au>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Peter Rosin <peda@axentia.se>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM
Date: Fri, 14 Apr 2017 08:58:50 +0900 [thread overview]
Message-ID: <20170413235850.GA6944@verge.net.au> (raw)
In-Reply-To: <20170413212059.unh2mfo2w4oc4t33@piout.net>
On Thu, Apr 13, 2017 at 11:20:59PM +0200, Alexandre Belloni wrote:
> On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote:
> > Hello Peter,
> >
> > On 04/13/2017 05:43 PM, Peter Rosin wrote:
> > > On 2017-04-13 20:28, Javier Martinez Canillas wrote:
> >
> > [snip]
> >
> > >>
> > >> eeprom@50 {
> > >> - compatible = "nxp,24c02";
> > >> + compatible = "nxp,24c02","atmel,24c02";
> > >> reg = <0x50>;
> > >> pagesize = <16>;
> > >> };
> > >>
> > >
> > > Sure, in principle. But not having a space after the commas is a real OCD
> > > trigger for me. My spine is rotating... :-)
> > >
> >
> > Right, Geert already pointed out. It's something I missed in my sed script
> > so I got it wrong in all the DTS :(
> >
> > I'll fix my script and send a v2.
> >
>
> That would be v3, right? ;)
>
> > > Anyway, with those whitespace fixes (and without them too, but please):
> > > Acked-by: Peter Rosin <peda@axentia.se>
> > >
> >
> > Thanks for the review!
> >
>
> I'd like to be copied on the first patches to ensure they are applied
> before applying that one. (Also, it is probably too late for 4.12 anyway
> because we are past rc6).
Ditto
next prev parent reply other threads:[~2017-04-13 23:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170413182839.25381-1-javier@osg.samsung.com>
2017-04-13 18:28 ` [PATCH v2 01/22] dt-bindings: i2c: eeprom: Document manufacturer used as generic fallback Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 02/22] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 03/22] ARM: dts: omap: Add generic compatible string for I2C EEPROM Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 04/22] ARM: dts: turris-omnia: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 05/22] ARM: dts: at91: " Javier Martinez Canillas
2017-04-13 20:43 ` Peter Rosin
2017-04-13 21:09 ` Javier Martinez Canillas
2017-04-13 21:20 ` Alexandre Belloni
2017-04-13 23:46 ` Javier Martinez Canillas
2017-04-13 23:58 ` Simon Horman [this message]
2017-04-13 18:28 ` [PATCH v2 06/22] ARM: dts: efm32: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 07/22] ARM: dts: imx: " Javier Martinez Canillas
2017-04-14 3:14 ` Shawn Guo
2017-04-13 18:28 ` [PATCH v2 08/22] ARM: dts: keystone: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 09/22] ARM: dts: lpc18xx: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 10/22] ARM: dts: r7s72100: " Javier Martinez Canillas
2017-04-13 19:52 ` Geert Uytterhoeven
2017-04-13 18:28 ` [PATCH v2 11/22] ARM: dts: koelsch: " Javier Martinez Canillas
2017-04-13 19:52 ` Geert Uytterhoeven
2017-04-13 18:28 ` [PATCH v2 12/22] ARM: dts: socfpga: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 13/22] ARM: dts: uniphier: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 14/22] ARM: dts: zynq: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 15/22] arm64: dts: ls1043a: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 16/22] arm64: zynqmp: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 17/22] powerpc/5200: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 18/22] powerpc/fsl: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 19/22] powerpc/512x: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 20/22] powerpc/83xx: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 21/22] powerpc/5200: " Javier Martinez Canillas
2017-04-13 18:28 ` [PATCH v2 22/22] powerpc/44x: " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413235850.GA6944@verge.net.au \
--to=horms@verge.net.au \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox