From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbdDNKfw (ORCPT ); Fri, 14 Apr 2017 06:35:52 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44847 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbdDNKfv (ORCPT ); Fri, 14 Apr 2017 06:35:51 -0400 Date: Fri, 14 Apr 2017 12:35:49 +0200 From: Alexandre Belloni To: Quentin Schulz Cc: nicolas.ferre@microchip.com, broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@free-electrons.com Subject: Re: [PATCH 2/2] spi: atmel: add deepest PM support to SAMA5D2 Message-ID: <20170414103549.szcy5ev26psnuu4i@piout.net> References: <20170414082243.23002-1-quentin.schulz@free-electrons.com> <20170414082243.23002-2-quentin.schulz@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170414082243.23002-2-quentin.schulz@free-electrons.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2017 at 10:22:43 +0200, Quentin Schulz wrote: > This adds deepest (Backup+Self-Refresh) PM support to the ATMEL SAMA5D2 > SoC's SPI controller. > > When resuming from deepest state, it is required to restore MR register > as the registers are lost since VDD core has been shut down when > entering deepest state on the SAMA5D2. > > Signed-off-by: Quentin Schulz Acked-by: Alexandre Belloni > --- > > v2: > - fix commit log explanation on why restoring the registers is required > after resuming from deepest state, > > drivers/spi/spi-atmel.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 247d920..1eb83c9 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1702,8 +1702,17 @@ static int atmel_spi_suspend(struct device *dev) > static int atmel_spi_resume(struct device *dev) > { > struct spi_master *master = dev_get_drvdata(dev); > + struct atmel_spi *as = spi_master_get_devdata(master); > int ret; > > + ret = clk_prepare_enable(as->clk); > + if (ret) > + return ret; > + > + atmel_spi_init(as); > + > + clk_disable_unprepare(as->clk); > + > if (!pm_runtime_suspended(dev)) { > ret = atmel_spi_runtime_resume(dev); > if (ret) > -- > 2.9.3 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com