Re: linux-next: build failure after merge of the rtc tree

Heiner Kallweit
2017-05-31T05:45:24Z

Am 31.05.2017 um 06:33 schrieb Stephen Rothwell:
> Hi Alexandre,
>
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
> drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no member named 'client'
> if (chip->alarm && (ds1307->client->irq > 0 ||
> ^
ds1307->client->irq would have to be replaced with ds1307->irq.
Same what the regmap patch does e.g. at line 1477.
The regmap patch removes member client from struct ds1307.

Rgds, Heiner

>
> Caused by commit
>
> 345b89453dda ("rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ")
>
> interacting with commit
>
> 11e5890b5342 ("rtc: ds1307: convert driver to regmap")
>
> I have used the rtc tree from next-20170530 for today.
>