From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756208AbdDPIEO (ORCPT ); Sun, 16 Apr 2017 04:04:14 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60681 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756024AbdDPIEI (ORCPT ); Sun, 16 Apr 2017 04:04:08 -0400 X-ME-Sender: X-Sasl-enc: GDRb5ErBEURDQM9t6paCDwnzDosMdMsSt1xLLvjq2kxg 1492329841 Date: Sat, 15 Apr 2017 22:50:32 +0200 From: Greg KH To: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, "Maciej S. Szmigiero" , stable@vger.kernel.org, Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: [backport v4.9] tpm_tis: use default timeout value if chip reports it as zero Message-ID: <20170415205032.GA17774@kroah.com> References: <20170415152622.14451-1-user@jsakkine-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170415152622.14451-1-user@jsakkine-mobl1> User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 15, 2017 at 06:26:22PM +0300, Jarkko Sakkinen wrote: > From: "Maciej S. Szmigiero" > > Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for > TPM access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) > no longer works. The initialization proceeds fine until we get and > start using chip-reported timeouts - and the chip reports C and D > timeouts of zero. > > It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic > means to override the chip returned timeouts") we had actually let > default timeout values remain in this case, so let's bring back this > behavior to make chips like Atmel 3203 work again. > > Use a common code that was introduced by that commit so a warning is > printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the > timeouts aren't chip-original. > > Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") > Cc: stable@vger.kernel.org > Signed-off-by: Maciej S. Szmigiero > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Jarkko Sakkinen What is the git commit id for this patch in Linus's tree? thanks, greg k-h