* [PATCH] Bluetooth: hci_ll: Fix NULL pointer deref on FW upload failure
[not found] <20170415194854.byado7bxupbdhivp@earth>
@ 2017-04-15 21:54 ` Sebastian Reichel
2017-04-16 18:32 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Reichel @ 2017-04-15 21:54 UTC (permalink / raw)
To: Sebastian Reichel, Marcel Holtmann, Gustavo Padovan, Rob Herring
Cc: linux-bluetooth, linux-kernel
Avoid NULL pointer dereference occurring due to freeing
skb containing an error pointer. It can easily be triggered
by using the driver with broken uart (i.e. due to misconfigured
pinmuxing).
Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support")
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
drivers/bluetooth/hci_ll.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index 485e8eb04542..adc444f309a3 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -537,8 +537,7 @@ static int read_local_version(struct hci_dev *hdev)
if (IS_ERR(skb)) {
bt_dev_err(hdev, "Reading TI version information failed (%ld)",
PTR_ERR(skb));
- err = PTR_ERR(skb);
- goto out;
+ return PTR_ERR(skb);
}
if (skb->len != sizeof(*ver)) {
err = -EILSEQ;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: hci_ll: Fix NULL pointer deref on FW upload failure
2017-04-15 21:54 ` [PATCH] Bluetooth: hci_ll: Fix NULL pointer deref on FW upload failure Sebastian Reichel
@ 2017-04-16 18:32 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2017-04-16 18:32 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Gustavo F. Padovan, Rob Herring, Linux Bluetooth, linux-kernel
Hi Sebastian,
> Avoid NULL pointer dereference occurring due to freeing
> skb containing an error pointer. It can easily be triggered
> by using the driver with broken uart (i.e. due to misconfigured
> pinmuxing).
>
> Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support")
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> drivers/bluetooth/hci_ll.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-16 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170415194854.byado7bxupbdhivp@earth>
2017-04-15 21:54 ` [PATCH] Bluetooth: hci_ll: Fix NULL pointer deref on FW upload failure Sebastian Reichel
2017-04-16 18:32 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox