From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linaro-kernel@lists.linaro.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack
Date: Mon, 17 Apr 2017 11:20:35 +0530 [thread overview]
Message-ID: <20170417055035.GI28191@vireshk-i7> (raw)
In-Reply-To: <20170321103950.GS25659@vireshk-i7>
On 21-03-17, 16:09, Viresh Kumar wrote:
> On 21-03-17, 10:37, Jon Hunter wrote:
> >
> > On 21/03/17 05:24, Viresh Kumar wrote:
> > > The size of the struct tegra_powergate is quite big and if any more
> > > fields are added to the internal genpd structure, following warnings are
> > > thrown:
> > >
> > > drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> >
> > Hmmm ... AFAICT the size of the tegra_powergate struct is 312 bytes
> > (based upon next-20170321) and so it looks like something massive needs
> > to be added to the genpd struct to blow this up to over 1024 bytes. Are
> > there some genpd changes in-flight that are causing this?
>
> https://marc.info/?l=linux-kernel&m=149000247329743&w=2
>
> This is up for discussion right now though and we don't know if it
> will surely get merged or not.
@Jon: Regardless of the above series, do you want this patch to be merged as it
will still be better to avoid keeping large structures on stack.
Else I would be required to keep this in my above series from now on.
--
viresh
next prev parent reply other threads:[~2017-04-17 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 5:24 [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack Viresh Kumar
2017-03-21 10:37 ` Jon Hunter
2017-03-21 10:39 ` Viresh Kumar
2017-04-17 5:50 ` Viresh Kumar [this message]
2017-04-24 10:55 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417055035.GI28191@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox