From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932948AbdDQHnC (ORCPT ); Mon, 17 Apr 2017 03:43:02 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35072 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932413AbdDQHm7 (ORCPT ); Mon, 17 Apr 2017 03:42:59 -0400 Date: Mon, 17 Apr 2017 15:42:44 +0800 From: Peter Chen To: Stefan Agner Cc: balbi@kernel.org, gregkh@linuxfoundation.org, peter.chen@nxp.com, k.opasiak@samsung.com, yoshihiro.shimoda.uh@renesas.com, colin.king@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: remove redundant self assignment Message-ID: <20170417074244.GA15565@b29397-desktop> References: <20170417031250.407-1-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170417031250.407-1-stefan@agner.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 16, 2017 at 08:12:50PM -0700, Stefan Agner wrote: > The assignment ret = ret is redundant and can be removed. > > Signed-off-by: Stefan Agner > --- > A very similar patch has been applied already last year, but there is > a second such assignment... > > -- > Stefan > > drivers/usb/gadget/udc/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index d685d82dcf48..b57bd53812fe 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) > goto out; > > ret = ep->ops->disable(ep); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = false; > Reviewed-by: Peter Chen -- Best Regards, Peter Chen