From: Eric Biggers <ebiggers3@gmail.com>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org, lkp@01.org, ltp@lists.linux.it
Subject: Re: [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail
Date: Mon, 17 Apr 2017 10:29:55 -0700 [thread overview]
Message-ID: <20170417172955.GA31469@gmail.com> (raw)
In-Reply-To: <20170417062641.GN31394@yexl-desktop>
On Mon, Apr 17, 2017 at 02:26:41PM +0800, kernel test robot wrote:
>
> FYI, we noticed the following commit:
>
> commit: bdf7c0f8bf282ba44827ce3c7fd7936c8e90a18a ("KEYS: fix dereferencing NULL payload with nonzero length")
> url: https://github.com/0day-ci/linux/commits/Eric-Biggers/KEYS-fix-dereferencing-NULL-payload-with-nonzero-length/20170403-102013
> base: https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git next
>
...
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
> user :notice: [ 45.447047] <<<test_start>>>
>
> user :notice: [ 45.447365] tag=add_key02 stime=1492169102
>
> user :notice: [ 45.447567] cmdline="add_key02"
>
> user :notice: [ 45.447685] contacts=""
>
> user :notice: [ 45.447826] analysis=exit
>
> user :notice: [ 45.448011] <<<test_output>>>
>
> user :notice: [ 45.448568] tst_test.c:760: INFO: Timeout per run is 0h 05m 00s
>
> user :notice: [ 45.449439] add_key02.c:65: FAIL: add_key() failed unexpectedly, expected EINVAL: EFAULT
In my opinion this is a valid behavior, and the test is just weird; it's passing
in *both* an unaddressable payload and an invalid description, so it's not clear
which case it's meant to be testing. (Generally, if a syscall will fail for
more than one reason, it's not guaranteed which error code you'll get.)
In any case, once we have a fix merged, it would be nice for there to be an ltp
test added for the "NULL payload with nonzero length" case with one of the key
types that crashed the kernel.
Eric
next prev parent reply other threads:[~2017-04-17 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 21:34 [PATCH] KEYS: fix dereferencing NULL payload with nonzero length Eric Biggers
2017-04-03 15:46 ` David Howells
2017-04-03 17:59 ` Eric Biggers
2017-04-03 19:20 ` David Howells
2017-04-03 21:30 ` Eric Biggers
2017-05-31 19:11 ` Eric Biggers
2017-04-17 6:26 ` [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail kernel test robot
2017-04-17 17:29 ` Eric Biggers [this message]
2017-04-20 12:57 ` [LTP] " Cyril Hrubis
2017-04-21 4:43 ` Eric Biggers
2017-06-02 13:43 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417172955.GA31469@gmail.com \
--to=ebiggers3@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@01.org \
--cc=ltp@lists.linux.it \
--cc=stable@vger.kernel.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).