From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753104AbdDRErd (ORCPT ); Tue, 18 Apr 2017 00:47:33 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33922 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbdDREra (ORCPT ); Tue, 18 Apr 2017 00:47:30 -0400 Date: Mon, 17 Apr 2017 21:47:53 -0700 From: Chewie Lin To: Greg KH Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Message-ID: <20170418044752.GA6339@Cassini.Home> References: <20170417235848.5572-1-linsh@oregonstate.edu> <20170417235848.5572-2-linsh@oregonstate.edu> <20170418041411.GA29075@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170418041411.GA29075@kroah.com> User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > #417: FILE: main_usb.c:417: > > + "usb_device_reset fail status=%d\n", status); > > > > total: 0 errors, 1 warnings, 1058 lines checked > > > > And after fix: > > > > main_usb.c has no obvious style problems and is ready for submission. > > > > Signed-off-by: Chewie Lin > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > > index 9e074e9daf4e..71c4511b4cff 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(&priv->usb->dev, > > - "usb_device_reset fail status=%d\n", status); > > + "%s fail status=%d\n", __func__, status); > > But the call that failed was called usb_device_reset(), right? Why is > this function even needed at all, have the caller call the correct > function instead please, and then this whole function can be deleted. > thanks greg. Yes, I think that's a good approach as well. I initially wanted to fix a coding style problem without touching the function calls, but I can definitely do that as well. linsh