From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Matt Brown <matt@nmatt.com>,
jmorris@namei.org, akpm@linux-foundation.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config
Date: Tue, 18 Apr 2017 14:40:57 +0100 [thread overview]
Message-ID: <20170418144057.1e9c2103@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20170417065055.GA21022@kroah.com>
> Since tty sessions are usually separated by different users, how would
> they have the same one and yet need something like this?
>
> Also, why not put this in the tty config section?
The normal attack use case people argue about is a rogue process on the
users machine sitting there waiting until the user has logged in to a
remote machine and is idle and then doing stuff.
Attackers of course don't bother doing that because it's easier to get
the user to run a different ssh client instead.
Alan
next prev parent reply other threads:[~2017-04-18 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 6:07 Patchset to Restrict Unprivileged TIOCSTI TTY Command Injection Matt Brown
2017-04-17 6:07 ` [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config Matt Brown
2017-04-17 6:50 ` Greg KH
2017-04-18 4:29 ` Matt Brown
2017-04-18 13:40 ` Alan Cox [this message]
2017-04-18 15:49 ` [kernel-hardening] " Kees Cook
2017-04-17 6:07 ` [PATCH 2/4] add tiocsti_restrict variable Matt Brown
2017-04-17 6:51 ` Greg KH
2017-04-17 6:07 ` [PATCH 3/4] restrict unprivileged TIOCSTI tty ioctl Matt Brown
2017-04-17 6:53 ` Greg KH
2017-04-17 14:18 ` [kernel-hardening] " Jann Horn
2017-04-17 16:18 ` Matt Brown
2017-04-17 6:07 ` [PATCH 4/4] added kernel.tiocsti_restrict sysctl Matt Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418144057.1e9c2103@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matt@nmatt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox