From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760856AbdDSILa (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Apr 2017 04:11:30 -0400
Received: from merlin.infradead.org ([205.233.59.134]:52692 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760498AbdDSILZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Apr 2017 04:11:25 -0400
Date: Wed, 19 Apr 2017 10:11:16 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        Eric Dumazet <edumazet@google.com>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-pm@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Rik van Riel <riel@redhat.com>
Subject: Re: [patch V2 08/10] timer: Implement the hierarchical pull model
Message-ID: <20170419081116.GA3029@worktop.programming.kicks-ass.net>
References: <20170418111102.490432548@linutronix.de>
 <20170418111401.016420305@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170418111401.016420305@linutronix.de>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 18, 2017 at 01:11:10PM +0200, Thomas Gleixner wrote:
> +static struct tmigr_group *tmigr_get_group(unsigned int node, unsigned int lvl)
> +{
> +	struct tmigr_group *group;
> +
> +	/* Try to attach to an exisiting group first */
> +	list_for_each_entry(group, &tmigr_level_list[lvl], list) {
> +		/*
> +		 * If @lvl is below the cross numa node level, check
> +		 * whether this group belongs to the same numa node.
> +		 */
> +		if (lvl < tmigr_crossnode_level && group->numa_node != node)
> +			continue;
> +		/* If the group has capacity, use it */
> +		if (group->num_childs < tmigr_childs_per_group) {
> +			group->num_childs++;
> +			return group;
> +		}

This would result in SMT siblings not sharing groups on regular Intel
systems, right? Since they get enumerated last.

> +	}
> +	/* Allocate and set up a new group */
> +	group = kzalloc_node(sizeof(*group), GFP_KERNEL, node);
> +	if (!group)
> +		return ERR_PTR(-ENOMEM);
> +
> +	if (!zalloc_cpumask_var_node(&group->cpus, GFP_KERNEL, node)) {
> +		kfree(group);
> +		return ERR_PTR(-ENOMEM);
> +	}

So if you place that cpumask last, you can do:

	group = kzalloc_node(sizeof(*group) + cpumask_size(),
	                     GFP_KERNEL, node);

> +	tmigr_init_group(group, lvl, node);
> +	/* Setup successful. Add it to the hierarchy */
> +	list_add(&group->list, &tmigr_level_list[lvl]);
> +	return group;
> +}