From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Carlo Caione <carlo@endlessm.com>,
Carlo Caione <carlo@caione.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode
Date: Wed, 19 Apr 2017 13:12:26 -0700 [thread overview]
Message-ID: <20170419201226.GB17351@fury> (raw)
In-Reply-To: <CAHp75VcPm878U+m9s+AEdy7nnkkSWoqB1j2w5b5SuwSH31Y=sQ@mail.gmail.com>
On Wed, Apr 19, 2017 at 07:23:39PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 14, 2017 at 2:07 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Thu, Apr 13, 2017 at 10:09:43PM +0200, Carlo Caione wrote:
> >> On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> >> > On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote:
>
> > EINVAL is being used to broadly here. If the input values are incorrect, then
> > yes -EINVAL is the right response. However, if the query was unsuccessful, that
> > is more appropriately -EIO.
> >
> > If the handle/method doesn't exist, that would be -ENXIO.
> >
> > However, your changes make the driver self-consistent and I'll apply them as is
> > to testing.
>
> Darren, if it's not yet in for-next, I would like Carlo to update his
> patch 1. I think it's better if we not shadow negative error code from
> the callee.
See my response in the V2 Carlo submitted.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-04-19 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 13:56 [PATCH 0/2] hp-wmi: Fix dock status and tablet mode reporting Carlo Caione
2017-04-09 13:56 ` [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state Carlo Caione
2017-04-19 16:21 ` Andy Shevchenko
2017-04-19 16:24 ` Carlo Caione
2017-04-19 16:26 ` Andy Shevchenko
2017-04-09 13:56 ` [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Carlo Caione
2017-04-13 18:21 ` Darren Hart
2017-04-13 20:09 ` Carlo Caione
2017-04-13 23:07 ` Darren Hart
2017-04-19 16:23 ` Andy Shevchenko
2017-04-19 20:12 ` Darren Hart [this message]
2017-04-13 6:28 ` [PATCH 0/2] hp-wmi: Fix dock status and tablet mode reporting Carlo Caione
2017-04-13 17:23 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419201226.GB17351@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox