From: Keith Busch <keith.busch@intel.com>
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Xiaolong Ye <xiaolong.ye@intel.com>
Subject: Re: irq/affinity: Fix extra vecs calculation
Date: Wed, 19 Apr 2017 18:45:56 -0400 [thread overview]
Message-ID: <20170419224555.GA21311@localhost.localdomain> (raw)
In-Reply-To: <20170419223205.GA29640@outlook.office365.com>
On Wed, Apr 19, 2017 at 03:32:06PM -0700, Andrei Vagin wrote:
> This patch works for me.
Awesome, thank you much for confirming, and again, sorry for the
breakage. I see virtio-scsi is one reliable way to have reproduced this,
so I'll incorporate that into tests before posting future kernel core
patches.
I'll send this fix with change log shortly.
> > ---
> > diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> > index d052947..eb8b689 100644
> > --- a/kernel/irq/affinity.c
> > +++ b/kernel/irq/affinity.c
> > @@ -98,13 +98,16 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd)
> > int ncpus, v, vecs_to_assign, vecs_per_node;
> >
> > /* Spread the vectors per node */
> > - vecs_per_node = (affv - curvec) / nodes;
> > + vecs_per_node = (affv - (curvec - affd->pre_vectors)) / nodes;
> >
> > /* Get the cpus on this node which are in the mask */
> > cpumask_and(nmsk, cpu_online_mask, cpumask_of_node(n));
> > --
prev parent reply other threads:[~2017-04-19 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 17:28 [PATCH] irq/affinity: Fix extra vecs calculation Keith Busch
2017-04-13 21:46 ` [tip:irq/urgent] " tip-bot for Keith Busch
2017-04-19 16:20 ` Andrei Vagin
2017-04-19 17:03 ` Keith Busch
2017-04-19 19:11 ` Andrei Vagin
2017-04-19 19:53 ` Andrei Vagin
2017-04-19 21:53 ` Keith Busch
2017-04-19 22:32 ` Andrei Vagin
2017-04-19 22:45 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419224555.GA21311@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=avagin@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox