From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032045AbdDTOAA (ORCPT ); Thu, 20 Apr 2017 10:00:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43374 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031716AbdDTN74 (ORCPT ); Thu, 20 Apr 2017 09:59:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1BBF272B0A Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bhe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1BBF272B0A Date: Thu, 20 Apr 2017 21:59:47 +0800 From: Baoquan He To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, keescook@chromium.org, dave.jiang@intel.com, dan.j.williams@intel.com, hpa@zytor.com, tglx@linutronix.de, dyoung@redhat.com Subject: Re: [PATCH 0/4] Handle memmap and mem kernel options in boot stage kaslr Message-ID: <20170420135947.GE2311@x1> References: <1492436099-4017-1-git-send-email-bhe@redhat.com> <20170418094753.q2siun6mkjoneqcn@gmail.com> <20170418113810.GA14395@x1> <20170418125154.37rlz7ufb7bxukp4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170418125154.37rlz7ufb7bxukp4@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 20 Apr 2017 13:59:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18/17 at 02:51pm, Ingo Molnar wrote: > > * Baoquan He wrote: > > > On 04/18/17 at 11:47am, Ingo Molnar wrote: > > > > > > * Baoquan He wrote: > > > > > > > People reported kernel panic occurs during system boots up with mem boot option. > > > > After checking code, several problems are found about memmap= and mem= in boot stage > > > > kaslr. > > > > > > > > *) In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), only one memmap > > > > entry is considered and only the last one if multiple memmap entries are specified. > > > > > > > > *) mem= and memmap=nn[KMG] are not considered yet. They are used to limit max address > > > > of system. Kernel can't be randomized to be above the limit. > > > > > > > > *) kernel-parameters.txt doesn't tell the updated behaviour of memmap=. > > > > > > > > This patchset tries to solve above issues. > > > > > > > > Baoquan He (4): > > > > param: Move function next_arg to lib/cmdline.c for later reuse > > > > KASLR: Parse all memmap entries in cmdline > > > > KASLR: Handle memory limit specified by memmap and mem option > > > > doc: Update description about memmap option in kernel-parameter.txt > > > > > > > > Documentation/admin-guide/kernel-parameters.txt | 9 ++ > > > > arch/x86/boot/compressed/cmdline.c | 2 +- > > > > arch/x86/boot/compressed/kaslr.c | 161 ++++++++++++++---------- > > > > arch/x86/boot/string.c | 8 ++ > > > > include/linux/kernel.h | 1 + > > > > kernel/params.c | 52 -------- > > > > lib/cmdline.c | 57 +++++++++ > > > > 7 files changed, 172 insertions(+), 118 deletions(-) > > > > > > I ported this series to tip:x86/boot (please post future versions against that), > > > and beyond a trivial conflict with e820entry => e820_entry, it fails to build on > > > 32-bit allmodconfig: > > > > > > ld: -r and -shared may not be used together > > > scripts/Makefile.build:294: recipe for target 'arch/x86/boot/compressed/kaslr.o' failed > > > > > > ... which could be due to bad relocations, but I've not dug any further. > > > > Thanks, Ingo! > > > > I will find a x86_32 system to try allmodconfig. > > No need, on a 64-bit system just do: > > make ARCH=i386 allmodconfig > > and build the kernel the regular way. Sorry for late update. I tried on a x86 64 system with "make ARCH=i386 allmodconfig", and saw the ld warning. I added a '-r' after -pie, the building passed. Seems including lib/ctype.c or lib/cmdline.c caused this. Will dig further to see what's going on. ifeq ($(CONFIG_X86_32),y) LDFLAGS += $(call ld-option, -pie -r) $(call ld-option, --no-dynamic-linker) else Thanks Baoquan