From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033572AbdDTUTs (ORCPT ); Thu, 20 Apr 2017 16:19:48 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:49148 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033124AbdDTUTq (ORCPT ); Thu, 20 Apr 2017 16:19:46 -0400 Date: Thu, 20 Apr 2017 13:19:43 -0700 From: Darren Hart To: Andy Shevchenko Cc: Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" , Carlo Caione Subject: Re: [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups Message-ID: <20170420201943.GA3209@fury> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2017 at 10:38:56AM +0300, Andy Shevchenko wrote: > On Thu, Apr 20, 2017 at 5:25 AM, Darren Hart wrote: > > From: "Darren Hart (VMware)" > > > > This series factors out some redundant code, cleans up a number of style issues, > > modernizes the sysfs usage, and cleans up the return paths. All told, the driver > > is reduced in size by 37 lines (3.6%). > > > > I do not have an HP laptop, so I'm hoping Carlo can help out with some testing. > > In particular we need to verify that hotkeys and sysfs continue to work as > > before. > > > > Series looks good to me except patch 2. So, > > Reviewed-by: Andy Shevchenko > > with above exception. I was on the fence with this one, which is why I separated it out. I'll drop it. Thanks for the review. -- Darren Hart VMware Open Source Technology Center