public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: priyalee.kushwaha@intel.com
Cc: paulmck@linux.vnet.ibm.com, shuah@kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk
Date: Fri, 21 Apr 2017 11:47:31 -0700	[thread overview]
Message-ID: <20170421184721.GA28159@cloud> (raw)
In-Reply-To: <1ad554b0025913fedf4ec3c7953d1a42fe1f0dde.1492879165.git.priyalee.kushwaha@intel.com>

On Sat, Apr 22, 2017 at 10:17:11AM -0700, priyalee.kushwaha@intel.com wrote:
> From: Priyalee Kushwaha <priyalee.kushwaha@intel.com>
> 
> Most OS distribution have awk in /usr/bin not in /bin
> Without this patch, kernel-devsrc fails to build as
> runtime dependency for srcu-cbmc script /bin/awk is
> not found.
> 
> Signed-off-by: Kushwaha, Priyalee <priyalee.kushwaha@intel.com>

For anyone that has it in /bin/awk, does it have a compatibility symlink
from /usr/bin/awk (or vice versa), or not?  If not, then this would
break the build for those folks.

We could just drop the shebang and the executable bit, and run "awk -f
modify_srcu.awk" from whatever script invokes this.

>  tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> index 8ff8904..c9e8bc5 100755
> --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> @@ -1,4 +1,4 @@
> -#!/bin/awk -f
> +#!/usr/bin/awk -f
>  
>  # Modify SRCU for formal verification. The first argument should be srcu.h and
>  # the second should be srcu.c. Outputs modified srcu.h and srcu.c into the
> -- 
> 2.10.0
> 

  parent reply	other threads:[~2017-04-21 18:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 17:17 [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk priyalee.kushwaha
2017-04-21 17:50 ` Paul E. McKenney
2017-04-24  3:24   ` Lance Roy
2017-04-24  3:33     ` Paul E. McKenney
2017-04-21 18:47 ` Josh Triplett [this message]
2017-04-21 21:52   ` Kushwaha, Priyalee
2017-04-21 22:05     ` Josh Triplett
2017-04-24  2:44       ` Paul E. McKenney
2017-04-24  9:04         ` Josh Triplett
2017-04-24  5:52 ` Lance Roy
2017-04-24 14:02 ` Shuah Khan
2017-04-24 17:02   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170421184721.GA28159@cloud \
    --to=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=priyalee.kushwaha@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox