From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426060AbdDUVmo (ORCPT ); Fri, 21 Apr 2017 17:42:44 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:51066 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426046AbdDUVmi (ORCPT ); Fri, 21 Apr 2017 17:42:38 -0400 Date: Fri, 21 Apr 2017 14:42:19 -0700 From: Darren Hart To: Arnd Bergmann Cc: Andy Shevchenko , Hans de Goede , Rajneesh Bhardwaj , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: INT33FE: add I2C dependency Message-ID: <20170421214219.GB31650@fury> References: <20170421210331.876697-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170421210331.876697-1-arnd@arndb.de> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2017 at 11:03:13PM +0200, Arnd Bergmann wrote: > When I2C is disabled, we get a link error: > > drivers/platform/built-in.o: In function `cht_int33fe_remove': > intel_cht_int33fe.c:(.text+0x8ba): undefined reference to `i2c_unregister_device' > drivers/platform/built-in.o: In function `cht_int33fe_probe': > intel_cht_int33fe.c:(.text+0x9ec): undefined reference to `i2c_acpi_new_device' > intel_cht_int33fe.c:(.text+0xa7a): undefined reference to `i2c_unregister_device' > > This adds a Kconfig dependency to ensure I2C is available to this > driver. > > Fixes: 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver") > Signed-off-by: Arnd Bergmann Thanks Arnd, Tobias submitted a fix a short time ago, it'll be in next tomorrow. Thanks! -- Darren Hart VMware Open Source Technology Center