From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1045947AbdDWUEu (ORCPT ); Sun, 23 Apr 2017 16:04:50 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33074 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1045886AbdDWUEp (ORCPT ); Sun, 23 Apr 2017 16:04:45 -0400 Date: Sun, 23 Apr 2017 13:04:42 -0700 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:rcu/urgent 11/11] include/linux/srcu.h:66:2: error: #error "Unknown SRCU implementation specified to kernel configuration" Reply-To: paulmck@linux.vnet.ibm.com References: <201704240331.GViOKDXV%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704240331.GViOKDXV%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17042320-0008-0000-0000-00000200E926 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006962; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00851484; UDB=6.00420755; IPR=6.00630268; BA=6.00005307; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015147; XFM=3.00000013; UTC=2017-04-23 20:04:42 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042320-0009-0000-0000-000034DF93FE Message-Id: <20170423200442.GU3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-23_17:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704230367 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2017 at 03:00:38AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent > head: 746ec1f689abc74dca72fdce4134decdbfaec295 > commit: 746ec1f689abc74dca72fdce4134decdbfaec295 [11/11] srcu: Fix Kconfig botch when SRCU not selected > config: sparc64-allnoconfig (attached as .config) > compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 746ec1f689abc74dca72fdce4134decdbfaec295 > # save the attached .config to linux build tree > make.cross ARCH=sparc64 > > All errors (new ones prefixed by >>): > > In file included from include/linux/notifier.h:15:0, > from include/linux/pm_qos.h:8, > from kernel/power/qos.c:32: > >> include/linux/srcu.h:66:2: error: #error "Unknown SRCU implementation specified to kernel configuration" > #error "Unknown SRCU implementation specified to kernel configuration" > ^~~~~ > In file included from include/linux/pm_qos.h:8:0, > from kernel/power/qos.c:32: > >> include/linux/notifier.h:77:21: error: field 'srcu' has incomplete type > struct srcu_struct srcu; > ^~~~ And it appears that there is much code that includes srcu.h without having "select SRCU", which underlines the point that SRCU is no longer optional. Patch below, pushing to -rcu as well. ------------------------------------------------------------------------ commit b0d5280678ad03d0b8dbdbe827c9e31c43923e02 Author: Paul E. McKenney Date: Sun Apr 23 12:50:59 2017 -0700 srcu: Make SRCU be built by default SRCU is optional, and included only if there is a "select SRCU" in effect. However, we now have Tiny SRCU, so this commit defaults CONFIG_SRCU=y. Reported-by: kbuild test robot Signed-off-by: Paul E. McKenney diff --git a/init/Kconfig b/init/Kconfig index fe72c12e06a5..42a346b0df43 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -521,6 +521,7 @@ config RCU_EXPERT config SRCU bool + default y help This option selects the sleepable version of RCU. This version permits arbitrary sleeping or blocking within RCU read-side critical