From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163348AbdDWUw4 (ORCPT ); Sun, 23 Apr 2017 16:52:56 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:33432 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1045923AbdDWUwu (ORCPT ); Sun, 23 Apr 2017 16:52:50 -0400 From: Marcos Paulo de Souza Cc: Marcos Paulo de Souza , Greg Kroah-Hartman , Bhumika Goyal , Arnd Bergmann , simran singhal , Tobias Klauser , Elise Lennion , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8192u: Fix sparse warning Date: Sun, 23 Apr 2017 17:51:17 -0300 Message-Id: <20170423205229.6347-1-marcos.souza.org@gmail.com> X-Mailer: git-send-email 2.9.3 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warning: rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types) rtl8192u/ieee80211/ieee80211_rx.c:1489:45: expected restricted __le16 rtl8192u/ieee80211/ieee80211_rx.c:1489:45: got unsigned short [unsigned] [usertype] Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type. Signed-off-by: Marcos Paulo de Souza --- Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one! drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c index 5241c50..3a6a533 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c @@ -1486,7 +1486,7 @@ static int ieee80211_qos_convert_ac_to_parameters(struct qos_param->flag[aci] = (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00; - qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit); + qos_param->tx_op_limit[aci] = ac_params->tx_op_limit; } return 0; } -- 2.9.3