From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163874AbdDXAzm (ORCPT ); Sun, 23 Apr 2017 20:55:42 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:44050 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163697AbdDXAzd (ORCPT ); Sun, 23 Apr 2017 20:55:33 -0400 Date: Mon, 24 Apr 2017 01:55:30 +0100 From: Al Viro To: Stephen Rothwell Cc: LKML , Linus Subject: Re: patch series moving compat syscalls from fs/compat.c Message-ID: <20170424005530.GU29622@ZenIV.linux.org.uk> References: <20170424103134.48baba07@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424103134.48baba07@canb.auug.org.au> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2017 at 10:31:34AM +1000, Stephen Rothwell wrote: > Hi Al, > > I couldn't easily find this patch series posted anywhere (I didn't try > too hard) so I sill just comment here. I first noticed them in the vfs > tree in linux-next today. > > Overall, I like what they day, but when I first created kernel/compat.c > (in 2002), Linus did not want the compat code sprinkled all over the > other files (due to the uglifiying effect of #ifdefs in the C code, and > because the compat layer was only secondary). He may have changed his > mind since then, but it is worth asking. The cleanups (including more > static functions) make it worth while for me, at least. > > It also might have been worth asking the original (and subsequent) > authors of the code for review and/or comments. FWIW, the same kind of stuff had been done before (e.g. compat variants of readv/writev moved to fs/read_write.c, compat aio syscalls to fs/aio.c, etc.) with no objections from anybody. The situation with kernel/compat.c is slightly different, but fs/compat.c contains very little shared infrastructure - almost all of it is straight "here's compat variant of this syscall, making use of the guts of the native one".