public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, keescook@chromium.org,
	mingo@kernel.org, dave.jiang@intel.com, dan.j.williams@intel.com,
	hpa@zytor.com, tglx@linutronix.de, dyoung@redhat.com,
	Jonathan Corbet <corbet@lwn.net>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description
Date: Mon, 24 Apr 2017 14:54:33 +0800	[thread overview]
Message-ID: <20170424065433.GB2310@x1> (raw)
In-Reply-To: <9ee7e238-3baf-332a-e77a-ea5ed8d9416b@cn.fujitsu.com>

On 04/24/17 at 11:53am, Dou Liyang wrote:
> 
> 
> At 04/24/2017 10:40 AM, Baoquan He wrote:
> > In commit:
> > 
> >   9710f581bb4c ("x86, mm: Let "memmap=" take more entries one time")
> > 
> > ... 'memmap=' was changed to adopt multiple, comma delimited values in a
> > single entry, so update the related description.
> > 
> > In the special case of only specifying size value without an offset,
> > like memmap=nn[KMG], memmap behaves similarly to mem=nn[KMG], so update
> > it too here.
> > 
> > Furthermore, for memmap=nn[KMG]$ss[KMG], an escape character needs be added
> > before '$' for some bootloaders. E.g in grub2, if we specify memmap=100M$5G
> > as suggested by the documentation, "memmap=100MG" gets passed to the kernel.
> > 
> > Clarify all this.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: linux-doc@vger.kernel.org
> > ---
> >  Documentation/admin-guide/kernel-parameters.txt | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index 986e443..4054328 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -2097,6 +2097,12 @@
> >  	memmap=nn[KMG]@ss[KMG]
> >  			[KNL] Force usage of a specific region of memory.
> >  			Region of memory to be used is from ss to ss+nn.
> > +			If @ss[KMG] is ommited, it equals to mem=nn[KMG]
> 
> s/ommited/omitted/

Right, thanks. Will see if there's other comment and update.

> 
> > +			which limits max address as nn[KMG].
> > +			Multiple different options can be put into one entry
> > +			with comma delimited to save space:
> > +			Example:
> > +				memmap=100M@2G,100M#3G,1G!1024G
> > 
> >  	memmap=nn[KMG]#ss[KMG]
> >  			[KNL,ACPI] Mark specific memory as ACPI data.
> > @@ -2109,6 +2115,9 @@
> >  			         memmap=64K$0x18690000
> >  			         or
> >  			         memmap=0x10000$0x18690000
> > +			Some bootloaders may need escape character before '$',
> > +			like in grub2, otherwise '$' and the following number
> > +			will be eaten.
> > 
> >  	memmap=nn[KMG]!ss[KMG]
> >  			[KNL,X86] Mark specific memory as protected.
> > 
> 
> 

      reply	other threads:[~2017-04-24  6:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  2:40 [PATCH v2 0/3] Handle memmap and mem kernel options in boot stage kaslr Baoquan He
2017-04-24  2:40 ` [PATCH v2 1/3] KASLR: Parse all memmap entries in cmdline Baoquan He
2017-04-24  8:00   ` Dou Liyang
2017-04-24  9:09     ` Baoquan He
2017-04-24  8:48   ` kbuild test robot
2017-04-24  8:48   ` [RFC PATCH] KASLR: mem_avoid_memmap_index can be static kbuild test robot
2017-04-24  9:00     ` Baoquan He
2017-04-24  9:04       ` [kbuild-all] " Fengguang Wu
2017-04-24  9:08         ` Baoquan He
2017-04-24  2:40 ` [PATCH v2 2/3] KASLR: Handle memory limit specified by memmap and mem option Baoquan He
2017-04-24 19:10   ` Kees Cook
2017-04-24  2:40 ` [PATCH v2 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description Baoquan He
2017-04-24  3:53   ` Dou Liyang
2017-04-24  6:54     ` Baoquan He [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424065433.GB2310@x1 \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=dyoung@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox