[PATCH 1/1] power: Fix unchecked return value of devm_kzalloc

Pan Bian
2017-04-24T00:34:36Z

Function devm_kzalloc() will return a NULL pointer. However, in function
isp1704_charger_probe(), the return value of devm_kzalloc() is directly
used without validation. This may result in a bad memory access bug.

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/power/supply/isp1704_charger.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/power/supply/isp1704_charger.c b/drivers/power/supply/isp1704_charger.c
index 4cd6899..2f02463 100644
--- a/drivers/power/supply/isp1704_charger.c
+++ b/drivers/power/supply/isp1704_charger.c
@@ -418,6 +418,8 @@ static int isp1704_charger_probe(struct platform_device *pdev)

pdata = devm_kzalloc(&pdev->dev,
sizeof(struct isp1704_charger_data), GFP_KERNEL);
+ if (pdata)
+ goto fail0;
pdata->enable_gpio = gpio;

dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);
--
1.9.1