From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus <torvalds@linux-foundation.org>
Subject: patch series moving compat syscalls from fs/compat.c
Date: Mon, 24 Apr 2017 10:31:34 +1000 [thread overview]
Message-ID: <20170424103134.48baba07@canb.auug.org.au> (raw)
Hi Al,
I couldn't easily find this patch series posted anywhere (I didn't try
too hard) so I sill just comment here. I first noticed them in the vfs
tree in linux-next today.
Overall, I like what they day, but when I first created kernel/compat.c
(in 2002), Linus did not want the compat code sprinkled all over the
other files (due to the uglifiying effect of #ifdefs in the C code, and
because the compat layer was only secondary). He may have changed his
mind since then, but it is worth asking. The cleanups (including more
static functions) make it worth while for me, at least.
It also might have been worth asking the original (and subsequent)
authors of the code for review and/or comments.
One thing I noticed from a quick look: do_handle_open() could now be static.
--
Cheers,
Stephen Rothwell
next reply other threads:[~2017-04-24 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 0:31 Stephen Rothwell [this message]
2017-04-24 0:55 ` patch series moving compat syscalls from fs/compat.c Al Viro
2017-04-24 2:57 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424103134.48baba07@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox