From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: <patches@opensource.wolfsonmicro.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in arizona_extcon_get_micd_configs()
Date: Mon, 24 Apr 2017 14:00:39 +0100 [thread overview]
Message-ID: <20170424130039.GG1594@localhost.localdomain> (raw)
In-Reply-To: <1a203761-76b9-bf3c-c034-0bb81fe6006a@users.sourceforge.net>
On Mon, Apr 24, 2017 at 02:43:55PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 23 Apr 2017 22:44:19 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> * Replace the specification of a data structure by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Actually fixes a bug on the alloc as well looks like the type was
wrong before.
Thanks,
Charles
next prev parent reply other threads:[~2017-04-24 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170424123857epcas2p24390d04885c9fc4c1980838ed8a4db06@epcas2p2.samsung.com>
2017-04-24 12:38 ` [PATCH 0/3] Extcon: Fine-tuning for three functions SF Markus Elfring
2017-04-24 12:40 ` [PATCH 1/3] extcon: Use devm_kcalloc() in extcon_dev_register() SF Markus Elfring
2017-04-24 12:41 ` [PATCH 2/3] extcon: Fix a typo in three comment lines SF Markus Elfring
2017-04-24 12:43 ` [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in arizona_extcon_get_micd_configs() SF Markus Elfring
2017-04-24 13:00 ` Charles Keepax [this message]
2017-04-24 13:34 ` SF Markus Elfring
2017-04-26 8:01 ` Charles Keepax
2017-05-23 9:34 ` [PATCH 0/3] Extcon: Fine-tuning for three functions Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424130039.GG1594@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox