From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Taeung Song <treeze.taeung@gmail.com>,
Jin Yao <yao.jin@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name
Date: Mon, 24 Apr 2017 18:06:45 +0200 [thread overview]
Message-ID: <20170424160645.GA4120@krava> (raw)
In-Reply-To: <20170424154450.GB2742@kernel.org>
On Mon, Apr 24, 2017 at 12:44:50PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Apr 20, 2017 at 11:24:30AM +0200, Jiri Olsa escreveu:
> > Recent commit broke command name strip in perf_event__get_comm_ids
> > function. It replaced left to right search for '\n' with rtrim,
> > which actually does right to left search. It occasionally caught
> > earlier '\n' and kept trash in the command name.
> >
> > Keeping the ltrim, but moving back the left to right '\n' search
> > instead of the rtrim.
>
> perf/urgent?
>
> > Fixes: bdd97ca63faa ("perf tools: Refactor the code to strip command name with {l,r}trim()")
>
> [acme@jouet linux]$ git tag --contains bdd97ca63faa
> perf-core-for-mingo-4.12-20170411
> perf-core-for-mingo-4.12-20170413
> perf-core-for-mingo-4.12-20170419
> [acme@jouet linux]$
>
> It is just in tip/perf/core, will put in acme/perf/core and push to Ingo
> in my next pull req.
sure, I did not check.. just thought it's urgent from time POV ;-)
thanks,
jirka
next prev parent reply other threads:[~2017-04-24 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 9:24 [PATCH perf/urgent] perf tools: Fix the code to strip command name Jiri Olsa
2017-04-20 10:17 ` Taeung Song
2017-04-20 10:35 ` Jiri Olsa
2017-04-20 10:42 ` Taeung Song
2017-04-20 10:49 ` Jiri Olsa
2017-04-24 11:37 ` Jiri Olsa
2017-04-24 15:44 ` Arnaldo Carvalho de Melo
2017-04-24 16:06 ` Jiri Olsa [this message]
2017-04-24 16:28 ` Arnaldo Carvalho de Melo
2017-04-24 21:17 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424160645.GA4120@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=treeze.taeung@gmail.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox